- 🇳🇱Netherlands idebr
My apologies for the comment in #13. I scanned the related issue without checking for the implementation of cache tags. In fact, there is explicit test coverage that shows the index list tag is missing for the 'None' plugin in ViewsDisplayCachingTest.
I agree with #12 that adding the list tag on the query is the preferred approach here, since it saves us the headache of adding an upgrade path for existing Search API views that use the existing None plugin.
Attached patch implements the following changes compared to #6:
- Adds test coverage to check the search_api_list cache tag is added when using the 'None' cache plugin
- Removed the getCacheTags implementation on the Search API Tag cache plugin, as its tags are now available through the SearchApiQuery
ViewsDisplayCachingTest still passes without changes to the Search API Time cache plugin, so it appears it is not necessary to remove the list tag again as suggested in #12
The last submitted patch, 15: 2905497-15.patch, failed testing. View results →
- 🇳🇱Netherlands idebr
Attached patch implements the following changes:
- Updated assertions for existing tests to include the list cache tag.
- Turns out the Search API Time-based cache plugin needs to removed the list cache tag after all.
The last submitted patch, 17: 2905497-17-test-only.patch, failed testing. View results →
- Status changed to RTBC
almost 2 years ago 10:36am 7 February 2023 - 🇳🇱Netherlands Lendude Amsterdam
Tested on our project and the correct search_api_list cache tag now gets added to all pages that show Search API generated Views.
- Status changed to Needs review
almost 2 years ago 5:07pm 18 February 2023 - 🇦🇹Austria drunken monkey Vienna, Austria
Thanks, great work! Also thanks @Lendude for testing.
Just two tiny corrections – if the test bot is happy with those then I’ll commit. -
drunken monkey →
committed 23562c34 on 8.x-1.x authored by
idebr →
Issue #2905497 by idebr, webflo, drunken monkey, rjacobs, borisson_:...
-
drunken monkey →
committed 23562c34 on 8.x-1.x authored by
idebr →
- Status changed to Fixed
almost 2 years ago 5:21pm 18 February 2023 - 🇦🇹Austria drunken monkey Vienna, Austria
Committed.
Thanks a lot again, everyone! Automatically closed - issue fixed for 2 weeks with no activity.