Empty nested field groups not hidden properly on edit/add/VBO forms

Created on 26 July 2017, over 7 years ago

Updated 16 September 2024, 3 months ago

Using 7.x-1.5, create a content type with the following nested field groups and no fields:

Level A
- Level B
Level 1
- Level 2
  - Level 3

The node add/edit forms (and any VBO forms you create) will have a single empty fieldset called "Level 1".

It seems as though this module can only hide the two deepest levels in any given set of nested groups.

As far as I can tell, this is because _field_group_is_empty_element() returns TRUE whenever any child element has a #type set, even though that child might just be another empty field group.

I've tried using 7.x-1.x-dev instead but that actually makes things worse and shows all of the fieldsets.

🐛 Bug report

Status

Needs work

Version

4.0

Component

Code

Created by

🇬🇧United Kingdom morbiD

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 9 months ago →
🇦🇺Australia marc.groth
This is still occurring in the latest version on the 3.x branch. The empty fieldsets also show on the 'Scheduled Transitions' tab (when using the https://drupal.org/project/scheduled_transitions module).

Attached is a patch that fixes this behavior. Not sure if it's the best way to achieve this; but it does the job for nested fieldsets (up to 3 x nested from my testing).
Comment 3 months ago →
🇦🇺Australia marc.groth
Attached is an updated patch to work on the latest version of the 3.x branch.
Status changed to Needs work 3 months ago1:47pm 16 September 2024
Comment 3 months ago →
🇧🇪Belgium joevagyok
Can we have an MR over 4.x please?

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024