Correctly check access and set correct revision_uid / empty revision_log on state change

Created on 11 July 2017, over 7 years ago
Updated 20 March 2023, almost 2 years ago

Problem/Motivation

1) Access to transitions does not factor in access to update the entity.
2) On state change the revision_uid does not reflect the user who took the action, it simply copies across from the last revision. Same for the revision_log message, it copies across from the last revision.

Proposed resolution

1) Check access as workbench_moderation does.
2) Set revision_uid and revision_log values on state transition.

Remaining tasks

Test, approve

User interface changes

NA

API changes

NA

Data model changes

NA

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇦🇺Australia fenstrat Australia

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024