Migration path for domain

During migration, I tried the patch provided by @unkelhoebbi at #17. When I used this patch with my custom code migrations in "custom_module/migrations" folder it worked. However when I applied the same patch and used it for "configuration entities" generated in my "custom_module/config/install" folder, it didn't work. The Nodes are no more attached to the Domains I had assigned in D7 version of site.

No matter whether I use d7_node_domain_access or d7_node_complete, it still doesn't connects the nodes to domains in migrated database.
More details can be found at : https://drupal.slack.com/archives/C226VLXBP/p1693222680688409

Any suggestions ?

Opened a MR and added three lines that avoid a warning when there is no source domain set

https://git.drupalcode.org/project/domain/-/merge_requests/51/diffs#03fe...

The code works for me migrating nodes. Given the support left for D7 I wouldn't bother adding any tests, that why I set it back to needs review

Just noting I used this patch #51 to successfully migrate node domain data into Drupal 10:

I added this to the migration yaml:

id: custom_d7_node_domain_access
# Other migration yaml then
source:
  # Needs this plugin
  plugin: d7_node_domain_access
  # Example node type
  node_type: article
process:
  # Other node fields then domain fields
  field_domain_access:
      -
        plugin: sub_process
        source: domain_access_node
        process:
          target_id: target_id
  field_domain_all_affiliates:
      -
        plugin: get
        source: domain_all_affiliates
  field_domain_source:
      -
        plugin: get
        source: domain_source

and ran the migration with drush:

drush migrate:import custom_d7_node_domain_access