- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
This needs a reroll for v2/v3 as it still mentions GroupContentEnabler. I also see no label being added for the new permission.
- last update
almost 2 years ago 9,627 pass - last update
almost 2 years ago 9,627 pass - Status changed to Needs review
almost 2 years ago 10:11am 25 May 2023 - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
This would work, I'm just carefully considering whether this is an API break or not.
Also:
if ($scope === 'any') { return "view $scope unpublished $this->pluginId entity"; } + + if ($scope === 'own' && $this->implementsOwnerInterface) { + return "view $scope unpublished $this->pluginId entity"; + }
Can simply be:
if ($scope === 'any' || $this->implementsOwnerInterface) { return "view $scope unpublished $this->pluginId entity"; }
- last update
almost 2 years ago 9,144 pass, 12 fail - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
I don't see how this is a problem, attaching a reworked patch.
The last submitted patch, 28: group-2876696-28.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
almost 2 years ago 9,339 pass, 1 fail The last submitted patch, 30: group-2876696-30.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
almost 2 years ago 9,339 pass, 1 fail - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
This should fix that.
The last submitted patch, 32: group-2876696-32.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
almost 2 years ago 9,627 pass - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
I need to learn to test locally before submitting stuff...
- Status changed to Fixed
almost 2 years ago 9:37am 26 May 2023 - π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
As this is a feature I've added it to a new minor version (3.1.0/2.1.0)
Automatically closed - issue fixed for 2 weeks with no activity.