Fix compatibility with menu_admin_per_menu

Created on 5 May 2017, over 7 years ago
Updated 26 April 2023, over 1 year ago

Problem/Motivation

The current code for the access checks is duplicated from the D7 Version of Menu admin per menu.

Proposed resolution

Remove the code that doesn't belong to this module, and add a comment that states that we "trust" the access checks from other contrib modules.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇩🇪Germany webflo

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States pookmish

    Raising priority because this is required to get Drupal 10 functional and fully featured as an upgrade from the 1.x versions.

  • 🇬🇧United Kingdom ChandeepKhosa

    Unless I've misunderstood this issue, I believe that this may no longer need a fix as menu_link_weight is working perfectly for me.
    I am using Drupal core (9.5.9), menu_link_weight (1.0.0-beta5) & menu_admin_per_menu (1.5.0).

  • 🇺🇸United States pookmish

    This issue is still a problem on the 2.x version. The issue was resolved in 1.x but not 2.x.

  • 🇫🇮Finland iSampo

    Along with the Menu Link module patch for Menu Admin Per Menu (from https://www.drupal.org/project/menu_link/issues/3092282 🐛 This module breaks the menu system with used with Menu Admin Per Menu Active ), combined with the current changes in this MR, the field is appearing correctly and by quick testing there seems to be no issues on 8.x-2.0-alpha6. Will be testing this further still.

    Attached is a patch with the current MR changes, for static composer patching.

Production build 0.71.5 2024