The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- πΊπΈUnited States joshuautley
@rivimey #46 following up on this as it relates to commerce_recurring.
Has anyone used the patch in #41 successfully in this use case?
- πΊπΈUnited States pmagunia Philadelphia πΊπΈ
Even after the patch in #41 Commerce Recurring fails upon uninstall for me:
commerce_recurring: The <em class="placeholder">Billing period</em> field type is used in the following fields: commerce_order.billing_period, commerce_order_item.billing_period
I haven't had much luck uninstalling Commerce Core either.