Remove default theme features

Created on 14 March 2017, over 7 years ago

Updated 23 May 2023, about 1 year ago

Problem/Motivation

Drupal provides a list of default features themes should support. Most of the themes don't override these, but they also ignore providing support for these. This causes confusion for the users since they have features on their site that doesn't provide any functionality.

List of features and reasoning why they don't make sense:

favicon, is there sites that don't want to provide favicon? Or should we encourage them to not have one?
logo, this isn't supported by core.
node_user_picture requires node module and doesn't make any sense without it.
comment_user_picture and comment_user_verification require comment module and doesn't make any sense without it.

Proposed resolution

Remove default theme features. Every theme should explicitly specify which features it supports. Support for these features should be also facilitated be the theme itself, not by modules like it works now. Maybe this can change after themes can set dependencies to modules. But I see these being placed in the theme as a best practice.

Remaining tasks

User interface changes

API changes

Default theme features are no longer set by theme system. BC breaks can be avoided by doing something in Stable theme, or in the worst case we can hard code that into the theme system.

Data model changes

📌 Task

Status

Active

Version

11.0 🔥

Component

Theme →

Last updated 1 minute ago

Maintained by
🇺🇸United States @effulgentsia
🇩🇪Germany @Fabianx
🇨🇦Canada @joelpittet
🇫🇮Finland @lauriii

Created by

🇫🇮Finland lauriii Finland

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇬🇧United Kingdom longwave UK
Thought about this after 🐛 TypeError: Argument 1 passed to Drupal\Core\Entity\EntityViewBuilder::view() must implement interface Drupal\Core\Entity\EntityInterface, null given, called in core/modules/node/node.module on line 559 Fixed which would probably not be a fatal error if the user picture on a node was rendered in a more normal way, such as via entity display settings, instead of being hardcoded in template_preprocess_node().

Should this become a meta to decide what to do about each of the settings? Providing BC will be tricky but I'm also not sure many people modify these features, they either use them as-is or just ignore them.
Comment about 1 year ago →
🇬🇧United Kingdom catch
Most of the entity-related parts of this are under ✨ [META] Expose Title and other base fields in Manage Display Active
Comment about 1 year ago →
🇬🇧United Kingdom catch

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024