Contrib.social

Add context to the CartBlock count text

Open on Drupal.org →
Created on 1 February 2017, about 8 years ago
Updated 5 November 2024, 5 months ago

The attached tiny patch solves two issues:

  • The text "@count item" / "@count items" needs a context since an item in a list isn't the same as an item in a cart - at least not in Norwegian.
  • After the items there is a link the full/editable cart which just says "Cart". I think it makes much more sense to make the link text "Go to cart" since you are already displaying the items in the cart.
🐛 Bug report
Status

Needs review

Version

3.0

Component

Cart

Created by

🇳🇴Norway hansfn

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 5 months ago →
    🇩🇪Germany Anybody Porta Westfalica
  • Merge request !363Add commerce cart context to @count item(s) translation string → (Open) created by Anybody
  • Comment 5 months ago →
    🇩🇪Germany Anybody Porta Westfalica

    Thanks all, I prepared a MR for this. I used "commerce cart" as context, as I think it's more distinct and clear. I left out the link labels as discussed. Please review.

  • Pipeline finished with Canceled
    5 months ago
    Total: 223s
    #329819
  • Pipeline finished with Success
    5 months ago
    Total: 657s
    #329821
  • Pipeline finished with Success
    3 months ago
    Total: 191s
    #383655
  • Pipeline finished with Failed
    3 months ago
    Total: 157s
    #383656
  • Pipeline finished with Success
    3 months ago
    Total: 158s
    #383659
  • Pipeline finished with Canceled
    3 months ago
    Total: 750s
    #385759
  • Pipeline finished with Failed
    3 months ago
    Total: 577s
    #385765
  • Pipeline finished with Success
    3 months ago
    Total: 1381s
    #385771
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024