- First commit to issue fork.
- Merge request !498New branch to reflect 3.x changes (original branch was based on 8.2 → (Open) created by scottsawyer
- 🇺🇸United States scottsawyer Atlanta
scottsawyer → changed the visibility of the branch 2846895-overriding-product-variation2 to hidden.
- 🇺🇸United States scottsawyer Atlanta
Hm, there is a test failure https://git.drupalcode.org/issue/commerce-2846895/-/jobs/6267257
I am not sure how that is related. There's one coding standards issue, easily fixed.
FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 56 | ERROR | [x] Parameter comment must end with a full stop (Drupal.Commenting.FunctionComment.ParamCommentFullStop)
- 🇮🇱Israel jsacksick
Ok, I'm not against the idea.
Can we please address the feedbacks I gave in the MR? Let's use property promotion in the event constructor.
Let's pass the variation first, then the title and also define return types for methods.