MESSAGE_QUEUE_POST_PROCESS event still gets dispatched after MESSAGE_OUTGOING_POST_PROCESS and MESSAGE_POST_PROCESS when skip_queue is true

Created on 15 January 2017, about 8 years ago
Updated 1 March 2025, about 1 month ago

Problem Statement

The SmsEvents::MESSAGE_QUEUE_POST_PROCESS event will still get dispatched after SmsEvents::MESSAGE_OUTGOING_POST_PROCESS and SmsEvents::MESSAGE_POST_PROCESS are dispatched if the gateway happens to have skip_queue TRUE.

Even though it is documented that skip_queue is not recommended in production, this is still a WTF for development and testing where the post process event handlers would behave funny in a test (for instance).

Proposed resolution

Filter out messages that have passed through a gateway with skip_queue on before passing them through the MESSAGE_QUEUE_POST_PROCESS event dispatch.

🐛 Bug report
Status

Closed: outdated

Version

1.0

Component

Core Framework

Created by

🇳🇬Nigeria almaudoh

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024