Page Manager support

RefreshLess introduces its own page variant that is an alternate for the Block one only. Hence it doesn't work with any module that relies on a different page variant. Like Page Manager. Eventually this should be supported, even if it's less effective.

Thanks to mglaman for requesting in IRC.

17:18:52 <mglaman> WimLeers: oh, and another side note: Refreshless breaks page manager completely
17:18:52 ⇐ ckrina quit (~ckrina@212.31.49.234)
17:18:53 <WimLeers> mglaman: thanks so much for the ping!
17:18:59 <mglaman> Since Refreshless replaces the page variant
17:19:05 <WimLeers> mglaman: quite possibly, RefreshLess specifically works with blocks
17:19:07 <WimLeers> mglaman: yeah
17:19:18 <mglaman> Tried making my personal app forkdin.com 100% Drupal, but Refreshless broke things
17:19:30 <WimLeers> mglaman: I've got a KPI for RefreshLess too, so I might have the chance to look into that. But making it work with Page Manager is not currently a top priority
17:19:44 <mglaman> yeah I didn't think so
17:19:45 <WimLeers> mglaman: interesting
17:20:08 <WimLeers> mglaman: But I promise I will at least look into it and make some proposals of possible directions for making it compatible with that
17:20:26 <WimLeers> mglaman: but the thing is that RefreshLess MUST have some sort of blocks-like thing
17:20:33 <WimLeers> mglaman: otherwise we don't know which parts to replace
17:20:43 <WimLeers> mglaman: or otherwise it's not quite effective
17:20:56 <WimLeers> mglaman: so Page Manager's APIs must be sufficiently complete for me to be able to do that
17:20:57 <mglaman> WimLeers: cool! Yeah I didn't know if Page Manager could provide _something_ which allows Refreshless to know what blocks it contains
17:21:06 ⇐ hampercm quit (~chris.ham@209-6-39-226.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com) Quit: hampercm
17:21:06 <WimLeers> yeah exactly, IDK either
17:21:07 <mglaman> I feel the blocker is Page Manager, honestly
17:21:09 <WimLeers> berdir: ^^
17:21:13 <WimLeers> well not necessarily
17:21:22 <WimLeers> I just don't know Page Manager AT ALL
17:21:45 <WimLeers> mglaman: I'll talk to tim.plunkett, who's on my team, and definitely knows a thing or two about it :)
17:21:58 <WimLeers> mglaman: now, go hf with your family! :)
17:21:58 → gambry joined  
17:22:12 <mglaman> WimLeers: sounds good! I wish I wasn't so tied up in client work so I could split some contrib time into these areas + commerce
17:22:15 <mglaman> thanks!
17:22:25 <WimLeers> mglaman: no worries, this is already super valuable
17:22:31 <WimLeers> mglaman: helping to validate stuff is super important too
17:22:38 <WimLeers> mglaman: code is not at all the only thing that matters
17:22:48 → StijnStroobants joined  ⇐ gambry_work and naveenvalecha quit  
17:24:44 <berdir> WimLeers: not really seeing a question, what are you pointing me to/asking me exactly?
17:24:57 → alexpott joined (~alexpott@drupal.org/user/157725/view)
17:25:53 <WimLeers> berdir: what mglaman said at 17:18:51, and then the subsequent discussion regarding RefreshLess + Page Manager
17:25:53 → naveenvalecha and clara_ joined  
17:26:26 <WimLeers> berdir: Just wondering if you know off the top of your head whether Pager Manager has the API infrastructure to know about the subsets (blocks or otherwise) to let RefreshLess works
17:26:29 <WimLeers> *work with it
17:27:51 <berdir> WimLeers: well, each variant has a build() method and can do whatever it wents. It's not really clear to me what refreshless would need, but every block inside a display should have the correct cacheability metadata
17:27:58 <berdir> .. it wants
17:28:54 → ellissd, naveenvalecha and chrfritsch joined  ⇐ Alienpruts, naveenvalechaAFK (was naveenvalecha) and dbalcomb quit  ↔ nvtest popped in  
17:37:06 <WimLeers> berdir: I'd need to be able to decorate each individual subsection thing (add some attribute for example) *and* be able to render them individually
17:37:23 <WimLeers> But I'll see then
17:37:25 <WimLeers> berdir: thanks
17:38:00 <berdir> WimLeers: yeah, I actually thought about that in context of lazy loading single blocks. It's pretty much impossible
17:38:42 <berdir> not without extending the API there
17:39:41 <berdir> WimLeers: while each block is separately rendered, all their configuration is stored in a single config entity, contexts are also provided by it and so on.
17:40:03 → jcloys joined  ⇐ musk_1107 and claudiu_cristea quit  ↔ kgoel nipped out  
17:42:21 <WimLeers> berdir: that's _exactly_ what I feared
17:42:23 <WimLeers> mglaman: ^^
17:44:00 → claudiu_cristea joined (~claudiu_c@86.120.24.124)
17:44:02 <mglaman> WimLeers: berdir thanks. That's also what I figured.
17:44:06 → adita joined (uid138634@gateway/web/irccloud.com/x-gsroocuubxcnnmaq)
17:44:16 <berdir> WimLeers: but replacing the whole variant/main block should work, just not single blocks
17:44:54 <WimLeers> yeah but that's far less effective
17:44:55 <mglaman> berdir: it currently breaks the page when enabled. Like the variant us overridden
17:45:04 <WimLeers> yeah it'd need to work differently for sure
17:45:06 ⇐ jcloys quit (~jcloys@pool-173-61-178-211.cmdnnj.fios.verizon.net) Remote host closed the connection
17:45:07 <WimLeers> But that's not the Q
17:45:11 <WimLeers> the Q is whether it's at all possible
17:45:18 <WimLeers> "not really" is what the answer seems to be
17:45:37 <WimLeers> Hopefully we can change that
17:45:45 ⇐ kgoel quit (~kgoel@nms.fjfi.cvut.cz) Ping timeout: 244 seconds
17:47:06 <berdir> I'm a bit confused. refreshless is about only replacing parts that changed when clicking on a link, right?
17:47:44 ⇐ SalahMessaoud quit (~SalahMess@drupal.org/user/1973140/view) Quit: Leaving
17:48:14 <berdir> a page is just that, a page. there are certain scenarios where one page has arguments and is actually shown on different pages while still having shared blocks but that seems very rare.
17:48:32 <berdir> so there seems little benefit for being able to only refresh single blocks of a while page?
17:48:39 <berdir> whole page
17:48:49 → jessehs joined  ⇐ alexpott quit  
17:49:02 <WimLeers> catch: https://www.drupal.org/node/2737719#comment-11796648 + https://www.drupal.org/comment/11796717#comment-11796717 :)
17:49:06 <Druplicon> https://www.drupal.org/node/2737719 => EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method 
            
              #2737719: EntityResource: Provide comprehensive test coverage: for every entity type, every format, every method →
             => 132 comments, 14 IRC mentions
17:49:23 ⇐ Heine quit (~Heine@drupal.org/user/17943/view) Remote host closed the connection
17:49:39 <WimLeers> berdir: usually quite a few blocks actually stay the same. Think user account, views, menu…
17:49:55 <berdir> WimLeers: not of a page, which just makes up the main block
17:49:58 → alexpott joined  ⇐ clara_ quit  
17:50:12 <WimLeers> berdir: IDK what that means
17:50:14 <berdir> we're not talking about page everywhere or so, right?
17:50:15 <WimLeers> can you rephrase?
17:50:22 <WimLeers> "page everywhere"?
17:50:42 → socketwench_ joined (~socketwen@162.243.250.249)
17:50:51 <berdir> WimLeers: panels/page manager by default is provides the main content. just like one view, one node, ...
17:51:08 <berdir> that main content then has a layout and has blocks inside
17:51:21 ⇐ socketwench quit (~socketwen@c-68-46-82-64.hsd1.mn.comcast.net) Ping timeout: 250 seconds
17:51:25 <WimLeers> berdir: hm ok
17:51:33 <WimLeers> berdir: I thought it took over much more than just the main block
17:51:39 <WimLeers> I'm confused now
17:51:50 <berdir> nope
17:51:55 <berdir> https://www.drupal.org/project/panels_everywhere is what I meant
17:52:08 <socketwench_> .
17:52:13 <berdir> that does take over the whole page, but there's no 8.x version of that yet
17:52:35 ⇐ nesimo quit (~mmanzano@242.red-79-159-92.dynamicip.rima-tde.net) Quit: Saliendo
17:52:39 <berdir> unless there is some other project that I'm not aware of

17:53:13 <WimLeers> ok
17:53:15 → rakeshjames joined (~rakeshjam@116.75.85.59)
17:53:16 <WimLeers> berdir++
17:53:31 <WimLeers> mglaman: berdir captured that in an issue: https://www.drupal.org/node/2830566
17:53:31 ⇐ jessehs quit (~jessehs@c-50-130-165-78.hsd1.nm.comcast.net) Ping timeout: 256 seconds
17:53:32 <Druplicon> https://www.drupal.org/node/2830566 => Page Manager support 
            
              
              
              ✨
              Page Manager support
                Closed: outdated
              
             => 0 comments, 1 IRC mention
17:53:39 <berdir> but I think what mglaman said is that even replacing the whole variant/page isn't working
17:54:12 <WimLeers> yeah that's by design
17:54:15 <WimLeers>   public function onBlockPageDisplayVariantSelected(PageDisplayVariantSelectionEvent $event) {
17:54:15 <WimLeers>     if ($event->getPluginId() === 'block_page') {
17:54:15 <WimLeers>       $event->setPluginId('refreshless_block_page');
17:54:15 <WimLeers>     }
17:54:15 <WimLeers>   }
17:54:17 ⇐ alexpott quit (~alexpott@drupal.org/user/157725/view) Ping timeout: 258 seconds
17:54:29 <WimLeers> it knows it can't work with just about anything, so it avoids breaking
17:55:08 <berdir> right, but that would be for the case where page manager replaces the sitewide variant
17:55:10 <WimLeers> That's why AFAIK you can't use Page Manager + Blocks on the same page
17:55:17 <berdir> page manager uses variants too, but inside a standard controller
17:55:20 <WimLeers> But IDK Page Manager enough
17:55:23 <WimLeers> cool
17:55:50 <berdir> so it doesn't touch the global page display variant, that is still block_page (I don't know what panels and so on already does, but page_manager has afaik no code to do that)
17:55:54 → clara_ and tedbow joined  
17:57:06 <WimLeers> ok