General usability cleanups

Created on 1 November 2016, over 8 years ago

Updated 3 April 2023, about 2 years ago

When rendering the pane form with prefix text the result has no link since the t() substitution fails.

default Prefix Text - Terms and Conditions
default Link Text - I agree with the %terms
#title => $this->t($prefix_text, ['%terms' => $link]) - "Terms and Conditions"

Should this be $prefix_text . ' ' . $link instead?
Does the default link text make more sense as "I agree with the terms and conditions"?

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States kscheirer Vallejo

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
tonytheferg
Rolled most of the UX and cleanup into this commit. The translate stuff is going to get fixed in this issue 📌 Fix the issues reported by phpcs Fixed . Thanks!
Comment about 2 years ago →
System Message

tonytheferg → committed c49221e0 on 8.x-1.x
Issue #2823939 by steveoliver, kscheirer: General usability cleanups
Comment about 2 years ago →
tonytheferg
Comment about 2 years ago →
tonytheferg
Comment about 2 years ago →
tonytheferg
Switch the semantics back to match commerce on the $summary .= etc.

Production build 0.71.5 2024