The image caption plugin works fine with images uploaded through the plugin, but breaks for images given as url (local or remote).
(It also breaks for older, existing images, but that's another issue :P)
When creating content the plugin can handle remote images too, but when editing the content the widget is not recognized.
- Turn on the image caption plugin for a ckeditor enabled input format while having the image upload function disabled.
- Create some content, insert an image using an url and enable caption.
- Save, then edit the content.
The image is recognized as the widget image with caption and behaves like one (caption editable, image button opens dialog with the image data in it)
The image is not recognized by ckeditor as an image with caption and can not be interacted with as such.
This seems to be the line (drupalimagecaption/plugin.js@112) causing the issue and removing those attribute checks seems to solve it.
var originalUpcast = widgetDefinition.upcast;
widgetDefinition.upcast = function (element, data) {
// if (element.name !== 'img' || !element.attributes['data-entity-type'] || !element.attributes['data-entity-uuid']) {
if (element.name !== 'img') {
return;
}
Any particular reason why those checks were there?
Needs review
1.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Patch #29 re-rolled to support CKEditor 4 in Contrib.
I did not re-roll the patch's tests. Looks like comment #31 mentions some good points, so maybe this patch isn't the best long-term going forward.
The last submitted patch, 35: 2822217-35.patch, failed testing. View results →