The EntityViewController:view() function set's the $page['#' . $page['#entity_type']] key. IMHO there is no need for that, because it's set by EntityViewBuilder::getBuildDefaults().
The problem is, when i want to replace entity x by entity z in hook_ENTITY_TYPE_build_defaults_alter, all my changes from the hook will be overwritten later in the view() function.
My use-case here is in the media_expire module, where i'am able to define a fallback image for a media entity. Is one media entity unpublished, i want to show the fallback entity instead.
Just remove that one line from EntityViewController:view(). It's already defined in EntityViewBuilder::getBuildDefaults().
Postponed: needs info
11.0 🔥
entity system
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I also agree with #5 that it's kinda scary, but the media_expire module seems to get around this by replacing the entire $build. So maybe this is a won't fix?
Since there hasn't been a follow up, going to close out. If still a bug in D11 please reopen.
Thanks all