Allow to change query string passthrough on a per-redirect basis (D8)

Created on 13 October 2016, almost 9 years ago
Updated 8 August 2023, about 2 years ago

Actually, for all redirection, we can decide if we passthrough querystring when redirecting, or not.
I think it must be a per redirection option, or a mix of per site, and per redirection.

✨ Feature request
Status

RTBC

Version

1.6

Component

Miscellaneous

Created by

πŸ‡«πŸ‡·France jossensei

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Assigning to myself as I'm triaging all RTBC issues.

  • Issue was unassigned.
  • Status changed to Postponed: needs info about 2 years ago
  • πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

    Thanks for the issue, patches, testing, and review. The patch still applies cleanly and the option is added to the form. I didn't test it because...

    I don't understand why this option is not a yes/no (true/false) option. What is default for?

    This logic:

    +      if ($redirect->getRedirectOption('passthrough_querystring') == 'always' || ($this->config->get('passthrough_querystring') && $redirect->getRedirectOption('passthrough_querystring') != 'never')) {
    

    adds the $request_query if they choose always or if they didn't choose never which means they must have chosen default.

    This seems overly complicated to me. Am I missing something? Moving to postponed for more explanation.

  • πŸ‡ΊπŸ‡ΈUnited States esod

    Agree on usability question in #13, but here's a patch for Drupal 10.5.x, redirect v1.12.

Production build 0.71.5 2024