- First commit to issue fork.
- 🇺🇸United States dcam
I didn't follow the recommended test plan. I created a unit test instead. Let me know if that isn't acceptable.
Follow-up to #2485385: Move highwater field support to the source plugin, and do not expose its internals on MigrationInterface →
Per alexpott's comment → :
Whilst reviewing this patch I pondered if we could set the highwater properly during rollback (see #125 and #127). After thinking about @mikeryan's response some more I think we should more the NULL setting from postRollback() to preRollback() this means that is the rollback fatals for any reason then the highwater is correctly indeterminate rather than wrong.
Good point - worst-case scenario setting it in preRollback(), you have to reimport everything if rollback fails. Worst-case scenario in postRollback() (as it is now), reimporting misses anything that was successfully rolledback - i.e., data loss.
Move the highwater code in SourcePluginBase from postRollback() to preRollback().
Implement the solution (Novice task).
Tests?
N/A
None
Needs work
11.0 🔥
migration system
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I didn't follow the recommended test plan. I created a unit test instead. Let me know if that isn't acceptable.