Dead code in VideoJsPlayerFormatter::isApplicable() & VideoJsPlayerListFormatter::isApplicable()

Created on 13 September 2016, over 8 years ago
Updated 25 November 2023, about 1 year ago

Discovered this after exporting a number of bundle fields to default config, and getting the following errors when accessing the
manage display tab for a custom entity.

Error: Call to a member function getBaseId() on null in /var/www/doris/web/modules/composer/videojs/src/Plugin/Field/FieldFormatter/VideoJsPlayerListFormatter.php on line 71

Error: Call to a member function getBaseId() on null in /var/www/doris/web/modules/composer/videojs/src/Plugin/Field/FieldFormatter/VideoJsPlayerFormatter.php on line 196

Sorry it's difficult to identify exactly what triggered it.

However, the code that throw's the error is dead and unused, and needs removal in any case.

Patch to follow.

πŸ› Bug report
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia thursday_bw

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024