- 🇩🇪Germany Anybody Porta Westfalica
As @quietone reported the issue to be still present in https://www.drupal.org/project/drupal/issues/2802371#comment-14964008 🐛 On a 404 page, none of the language switcher links have the 'is-active' class Active and the patch from #41 fixes it, we should reopen this.
It doesn't seem to be a duplicate, as otherwise it shouldn't be there since Drupal 8.6 where #2968541: ActiveLinkResponseFilter fails to set active link with query in non-alphabetical order → was fixed.
Please also see 🐛 On a 404 page, none of the language switcher links have the 'is-active' class Active and check out, if both fixes are needed and solving different problems.
- First commit to issue fork.
- Merge request !6820Add 'is-active' class to language block links of current language → (Open) created by johnzzon
- 🇸🇪Sweden johnzzon Gothenburg 🇸🇪
Also had this issue, we also saw it on views pages. Created MR with changes from #41 but rerolled to 11.x.
Seems to apply cleanly to 10.2.x as well and fixes the issue for us.
- Status changed to Needs work
10 months ago 8:04am 29 February 2024 - 🇩🇪Germany Anybody Porta Westfalica
Thranks @johnzzon! I just verified the MR is equal to the patch and it is! Thanks for that on 11.x!
As it was confirmed several times to be working (also by me), I just left one question that's not clear to me code-wise, see the comment.
Also we need a simple test to ensure this works as expected and the class is there in the case, where it wasn't before. Thanks!
- 🇬🇧United Kingdom joehuggans Harrogate, UK
Here's the patch from #41 re-rolled working with Drupal v 10.2.6.