drupal_random_key() documentation for length of returned string is wrong

Thanks for working on this. I see that D10 is replacing the characters (https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...), but D7 does not seems to do it (https://git.drupalcode.org/project/drupal/-/blob/7.x/includes/bootstrap....). So is the comment correct?

 *   A base-64 encoded string, with + replaced with -, / with _ and any =
 *   padding characters removed.

Those characters are replaced by drupal_base64_encode().

function drupal_random_key($byte_count = 32) {
  return drupal_base64_encode(drupal_random_bytes($byte_count));
}

function drupal_base64_encode($string) {
  $data = base64_encode($string);
  // Modify the output so it's safe to use in URLs.
  return strtr($data, array(
    '+' => '-',
    '/' => '_',
    '=' => '',
  ));
}

Oh, sorry, I overlooked that the function is calling drupal_base64_encode() instead of standard base64_encode(). Then I think this is correct and the same as we have in D10. RTBC, thanks!

Committed and pushed this, thanks everyone!

poker10 → closed merge request !7511

Automatically closed - issue fixed for 2 weeks with no activity.