SqlContentEntityStorageSchema::getDedicatedTableSchema assumes that a fields property definitions matches the columns

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Tried to reproduce this on HEAD using a base field on Node:

1. Install standard
2. Add the following to node.post_update.php:

function node_post_update_foo(): void {
  $field_definition = BaseFieldDefinition::create('map')
    ->setLabel(t('Foo'))
    ->setRequired(TRUE)
    ->setDisplayConfigurable('form', FALSE)
    ->setDisplayConfigurable('view', FALSE);
  $definition_update_manager = \Drupal::entityDefinitionUpdateManager();
  $definition_update_manager->installFieldStorageDefinition('foo', 'node', 'node', $field_definition);
}

3. Add the following to Node::baseFieldDefinitions:

    $fields['foo'] = BaseFieldDefinition::create('map')
      ->setLabel(t('Foo'))
      ->setRequired(TRUE)
      ->setDisplayConfigurable('form', FALSE)
      ->setDisplayConfigurable('view', FALSE);

4. Run drush updb -y

No errors, the field is added to the node_field_data table

5. Try the opposite:

function node_post_update_bar(): void {
  $definition_update_manager = \Drupal::entityDefinitionUpdateManager();
  if ($field_definition = $definition_update_manager->getFieldStorageDefinition('foo', 'node')) {
    $definition_update_manager->uninstallFieldStorageDefinition($field_definition);
  }
}

No errors, the field is removed from the node_field_data table.

Has this been fixed elsewhere?