Check for features exclusions before adding new dependency

Created on 25 February 2016, almost 9 years ago
Updated 1 June 2024, 7 months ago

Problem/Motivation

The features integration in this module checks for other modules that are implementing same subfields of a field_group, and tries to add that feature or module as a dependency. This works quite well in most cases, however it does not respect exclusions set by the feature itself.

Note: this problem seems to happen to us only when we use the drush command "drush features-update", updating modules through the features UI seems to cause no problems.

Example:
In the .info file of feature_a (enabled) we have the following line:
features_exclude[dependencies][feature_b] = feature_b

When updating Feature A through the Features UI management screen, the excluded dependency will not get added by field_group. However when updating the features through drush (drush features-update [name]), field_group will add feature_b as a dependency despite it being excluded.

Proposed resolution

Add a check in field_group.features.inc to only add a dependency when there is NO exclusion defined. See attached patch.

🐛 Bug report
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

🇳🇱Netherlands leendertdb

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024