ContentEntityInterface implements RevisionableInterface, but not all of the RevisionableInterface support revisions (e.g: taxonomy terms).
Before calling $entity->setNewRevision(FALSE); we should check if the entity allows revisions or not with $entity->getEntityType()->hasKey('revision').
a) Add a method RevisionableInterface::isRevisionable() that hides the implementation detail
or
b) Anyone would assume that objects implementing RevisionableInterface support revisions. Use it only where is needed, and use a trait if possible instead of having the implementation in ContentEntityBase.
Discuss
None.
Ideally, API additions only, so eligible for 8.1.0.
None.
Closed: works as designed
11.0 🔥
Worse Than Failure. Approximates the unpleasant remark made by Drupal developers when they first encounter a particular (mis)feature.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Hmm, appears this may have already been done elsewhere.
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...
This already exists.
The simplest way to use it is:
if ($node->getEntityType()->isRevisionable()) {
// Safe to call $node->getRevisionId();.
}