Menu UI searches links by incorrect uri

Confirming this is still an issue in the latest D10.

Steps to replicate:

Install a standard site
Add a new menu
Add the new menu to the Article content type.
Add a new article
Add a menu link into the new menu
Add a menu link into the main navigation.
Go to the edit form for the article. The main menu link should be the default, but the menu link from the new menu is.

I'll use these steps to write a test next week if nobody else has. :)

Added a test for this. Potentially you could argue that it could be a kernal/unit test that just tests the output of menu_ui_get_menu_link_defaults but I made it a functional test to ensure the correct value is always being added to the node-edit form.

No intediff, the code isn't changed besides adding the test.

The last submitted patch, 22: 2665608-22-tests-only.patch, failed testing. View results →

Attached patch in #22 resolves the issue.

I took following steps to validate the issue:
- Create a new menu (Test Menu)
- Enable that menu for basic content type.
- Create a node and two menu link content pointing to each node.
- Noticed that before patch default menu was not taking priority i.e. Test-menu was set in "parent link" field
- After applying the patch, default menu is given priority.

Patch contains the valid tests and test-only patch shows the issue.

Looks good for RTBC

Updated the issue summary as well.

I came here to update the title. But first, I thought I would test this. I tested on a fresh Drupal 10.1.x, standard install. I was not able to reproduce the problem with either the steps in the issue summary or #25. I applied the patch and ran the test with out the fix. It does fail. I am puzzled.

Let me re-iterate the steps that I took:
- Created a new menu called "Test navigation"
- Edit article content type's setting enable "Main navigation" and "Test Navigation" menu items.
- Content type's setting form should look like this one

- Now we can visit "admin/structure/menu" and create new menu links under each menu "Main navigation" and "Test navigation"
With this step we should have two links that points to same node. One link is in "Main nav" and another is in "Test nav"
- Later we visit the node edit form and see that parent menu is selected as "Test navigation". Actually it should be the "Main navigation" since "Main navigation" is set as the default one.
This is how it looks like on node edit form

The last submitted patch, 22: 2665608-22.patch, failed testing. View results →

The last submitted patch, 22: 2665608-22.patch, failed testing. View results →

@mohit_aghera Thank you for providing clear manual test instructions!

Committed and pushed b9b388eeb7 to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.