Don't add dot with inline comments containing code with semicolon

Created on 3 November 2015, over 8 years ago

Updated 22 June 2023, about 1 year ago

This code:

    //$transaction->payload['vps_status'] = 'TIMEOUT';

is converted into:

    // $transaction->payload['vps_status'] = 'TIMEOUT';.

with dot at the end.

Tested with command: phpcbf --standard=Drupal .

Other example:

  //dsm($vars['day_items']);

into:

  // dsm($vars['day_items']);.

So my suggestion is to not add the dot, when there is already some punctuation at the end (such as semicolon, or comma, etc.), so at the same time it'll solve the problem with adding dot at the end of the PHP code.

🐛 Bug report

Status

Active

Version

2.0

Component

Review/Rules

Created by

🇬🇧United Kingdom kenorb

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇳🇿New Zealand quietone New Zealand
Just noting that the related issue in the Coding Standards project has been closed as won't fix. It seems that will support closing this long standing issue.
Comment about 1 year ago →
🇬🇧United Kingdom jonathan1055
OK. So #2742881: Can inline comments end with semicolons → is now closed as 'wont fix', meaning that inline comments cannot end with a semicolon. That's fine.

Therefore, is the proposition that Coder should flag these as errors, but not automatically fix it by adding a dot. It is up to the developer to correct the inline code manually, in what ever way they want to.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024