Remove placeholdering of node links

Created on 24 August 2015, over 9 years ago
Updated 16 February 2025, 8 days ago

Problem/Motivation

The node links of each node are built using a lazy loader. Which means they are not cached and need to be rebuilt on every page.

On a default article node, that is about 10% of the whole processing time, mostly because of comment.module. Note that this also happens when e.g. displaying a teaser of 20 nodes on the frontpage.

The main reason this was done is that those links are often related to specific permissions and are sometimes not cacheable well. However, when we did this, we didn't have the cache context bubbling and other tools that we have now.

#2530846: Fix and improve comment cache tag usage makes comment links cacheable, the only remaining problem then are statistic counters. See that issue for some discussion on that, still need to take it over to this.

Proposed resolution

Remove the lazy builder, build node links directly. Figure out what to do with statistics view counters.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

8.0 ⚰️

Component

node system

Created by

🇨🇭Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
  • Performance

    It affects performance. It is often combined with the Needs profiling tag.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024