Consider not returning FALSE when saving a non-default entity revision

Created on 20 June 2015, almost 9 years ago
Updated 30 October 2023, 8 months ago

Problem/Motivation

In ContentEntityStorageBase::doSave():

    // @todo Consider returning a different value when saving a non-default
    //   entity revision. See https://www.drupal.org/node/2509360.
    $return = $entity->isDefaultRevision() ? SAVED_UPDATED : FALSE;

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

None

API changes

TBD

Data model changes

None

๐Ÿ› Bug report
Status

Needs work

Version

11.0 ๐Ÿ”ฅ

Component
Entityย  โ†’

Last updated about 5 hours ago

  • Maintained by
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom @catch
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland @Berdir
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany @hchonov
Created by

๐Ÿ‡ฎ๐Ÿ‡นItaly plach Venezia

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024