Serializing the database connection is dangerous and error-prone, make it unserializable again

Created on 31 March 2015, over 9 years ago

Updated 13 November 2023, about 1 year ago

Problem/Motivation

The SQLite and PostreSQL database drivers are doing some important things in their connection object constructor (e.g. altering the db prefix for SQLite, executing 'init_commands' for PostgreSQL) but Drupal\Core\Database\Connection::unserialize() is only doing the job of its own constructor by duplicating the code.

Proposed resolution

Call the connection object constructor instead of forcing each driver to duplicate its code.

Remaining tasks

Review, commit.

User interface changes

Nope.

API changes

Nope.

🐛 Bug report

Status

Fixed

Version

8.0 ⚰️

Component

Database →

Last updated about 13 hours ago

Maintained by
🇳🇱Netherlands @daffie

Created by

🇷🇴Romania amateescu

Live updates comments and jobs are added and updated live.

database connection

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇳🇱Netherlands johnv
I realize this is a very old, closed, issue, but the patch #29 indeed leads to lots of follow-up problems with random classes implementing DependencySerializationTrait.

I created a meta issue with a list of issues reporting this problem here: 🐛 LogicException: The database connection is not serializable (for string translations in Ajax callback) [META] Active ,
and proposed a solution in this old issue with many followers: 🐛 LogicException: The database connection is not serializable. Needs review .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024