- πΊπΈUnited States lwalley
I can confirm with patch from #57 I am able to export and take ownership of "file_type" and "file_display" components, with default hooks in place i.e. without needing file_entity patch in #2192391-83: Default file entities are not exportable by features (Sibling Issue) β or media patch #2104193-113: Default file entities are not exportable by features (Media File Entity Overridden) β .
We are exclusively using
drush
to manage features so I have not tested UI.One quirk to note is that if there is an alter hook that appends data (e.g. hook_file_default_types_alter() is used to append a mime type to the array), it will be added again on each feature export so you'll end up with duplicate entries. I've noticed this before in features so I don't think it is caused by the patch in #57 just something to watch out for.
Another minor weirdness is when running
drush fda -y
it will sometimes list our custom feature with media exports in it but just says it's in the default state; the expected behavior is that if there is no diff the custom feature would not be listed at all.I have not had time to uncover the cause of either if these minor issues, and do not consider them release blockers.
- last update
over 1 year ago 7 pass - last update
over 1 year ago 7 pass - last update
over 1 year ago 7 pass - last update
over 1 year ago 7 pass -
joseph.olstad β
committed f7a70693 on 7.x-2.x authored by
torotil β
Issue #2446485 by torotil, izmeez: Proper way to define module defaults
-
joseph.olstad β
committed f7a70693 on 7.x-2.x authored by
torotil β
-
joseph.olstad β
committed 2d09c664 on 7.x-2.x authored by
torotil β
Issue #2446485 by torotil, izmeez, Daniel Korte, brockfanning,...
-
joseph.olstad β
committed 2d09c664 on 7.x-2.x authored by
torotil β
- Status changed to Fixed
over 1 year ago 10:20pm 26 July 2023 - π¨π¦Canada joseph.olstad
Pushed this into dev , this also permits closing of an issue for file_entity
π Default file entities are not exportable by features (Sibling Issue) Closed: works as designed - π¦πΉAustria torotil
Hi! Thanks for taking the time to merge the patch. I hope it is still of use to some even though the Drupal 7 end-of-life is now only months away. At least itβs a nice gesture.
Issues like this are the reason weβve decided to move away from Drupal as a company years ago. It took 5 years for a maintainer of a module used on 250k+ sites to review a rather fundamental issue even though it has lead to workarounds in other popular modules (file_entity/media) already.
- π©πͺGermany donquixote
Hi! Thanks for taking the time to merge the patch. I hope it is still of use to some even though the Drupal 7 end-of-life is now only months away. At least itβs a nice gesture.
Sorry I did not follow up on this since the messages from 2020.
And thanks to @joseph.olstad for picking it up again.Drupal 7 end-of-life is now only months away.
For the record, this got pushed to Jan 2025.
https://www.drupal.org/about/drupal-7/end-of-life β Automatically closed - issue fixed for 2 weeks with no activity.