Ads_limit configuration contains inactive ads

Created on 22 January 2015, over 9 years ago
Updated 9 June 2023, about 1 year ago

It seems that the ads limit set in the block configuration includes inactive ads. This poses a problem if I have 10 ads and want to display 4 of them on a page, I might less than 4 if any number of the first 4 items found by the query are inactive. From what I can tell, the function simpleads_load_ads doesn't include whether the ad is active or not. This is why it returns inactive ads and you end up with less items than expected.

πŸ› Bug report
Status

Closed: won't fix

Version

1.8

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States mikeegoulding

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024