Unable to switch between secure/insecure based on URL pattern matches

Created on 6 November 2014, about 10 years ago
Updated 26 November 2024, 27 days ago

Securepages is no longer able to switch based on ignored/excluded paths that contain uppercase letters.

For example. On our site we set secure pages to "Make secure every page except the listed pages.", then typed "blankArtwork/pixlr" into the "pages" field, because that's the path we want to ignore. However, upon visiting it, it was still https. This worked fine in prior versions (6.x-1.9).

This bug is due to "$path = securepages_strtolower(trim($path, '/'));" on line 219 of securepages.module

Sometimes paths have uppercase letters, and setting the path to lowercase without setting the $pages and $ignore variables to lowercase means matching won't occur for paths that have uppercase letters. (trying to match blankArtwork/pixlr to blankartwork/pixlr results in failure).

Either remove the "$path = securepages_strtolower(trim($path, '/'));" on line 219, or set all the variables to lowercase before running the regex match.

No doubt this is currently breaking tons of websites like ours!

Thanks for all your hard work.

πŸ› Bug report
Status

Closed: outdated

Version

1.11

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States bitcookie

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • πŸ‡ΊπŸ‡¦Ukraine AstonVictor

    I'm closing it because the issue was created a long time ago without any further steps.

    if you still need it then raise a new one.
    thanks

Production build 0.71.5 2024