- last update
over 1 year ago Patch Failed to Apply - πΊπΈUnited States dcam
I'm biased because I created this issue, but I still think this is a bug.
teaser_length
is a non-functional admin setting. But it's not worth arguing over. We only need to decide what to do about it.I'm in favor of eliminating the setting entirely with no further action. As I've become more familiar with this module over the past few months and studied it again tonight, I've come to believe that there isn't any place that we can migrate this setting into. The entity views and Views don't utilize formatters with options. We would have to add something in order to make it do something. It has been non-functional for 8 years. Let's allow it to die quietly. Here's a patch.
- last update
over 1 year ago 147 pass - πΊπΈUnited States dcam
+++ b/tests/src/Functional/Update/AggregatorUpdateDeleteTeaserLengthSettingTest.php @@ -0,0 +1,33 @@ + /** + * Ensure all items in the aggregator_feeds queue are deleted. + */ + public function testUpdateHookN(): void {
I forgot to update this docblock when I copied it from another test I'd written. But I'm not going to bother changing it right now. We'll probably have to update this class's docblock to change the number of the update function it covers anyway. It can be fixed then.
- Status changed to RTBC
over 1 year ago 1:06am 7 September 2023 - Status changed to Needs review
over 1 year ago 4:36am 7 September 2023 - last update
over 1 year ago 151 pass - πΊπΈUnited States dcam
Rerolled since the update function number has to be updated.
- last update
over 1 year ago 151 pass - Status changed to Fixed
over 1 year ago 5:16am 7 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.