Ajax POST to statistics.php fails when using i18n with path prefix language code

Open on Drupal.org →

Created on 8 April 2014, almost 11 years ago

Updated 3 May 2023, almost 2 years ago

This is the Drupal 7 backport issue of #2172871: Async node hit counter data collection is broken when path-based language negotiation is used → which has been fixed for Drupal 8!

On a multilingual site using i18n, with Statistics enabled with both the settings "Count content views" and "Use Ajax to increment the counter" tracking fails, receiving a 404 for the statistics.php request because the wrong URL is generated in statistics.module.

For example: When visiting a node in RUSSIAN (using "russian") as the language prefix, the XHR requests url:
http://www.example.com/russian/modules/statistics/statistics.php
Instead of:
http://www.example.com/modules/statistics/statistics.php

🐛 Bug report

Status

Needs work

Version

7.0 ⚰️

Component

Last updated about 1 hour ago

No maintainer

Created by

🇺🇸United States ericpugh

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Open in Jenkins → Open on Drupal.org →
Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
2,149 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
run-tests.sh exception
Open in Jenkins → Open on Drupal.org →
Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
2,149 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
run-tests.sh exception
Open in Jenkins → Open on Drupal.org →
Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
2,149 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
2,149 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 7.4 & MySQL 5.7
last update almost 2 years ago
run-tests.sh exception
Comment almost 2 years ago →
🇸🇰Slovakia poker10
Created a separate issue for D10: 🐛 StatisticsLoggingTest does not truncate node_counter Fixed

It seems like these truncate calls are not needed, as there are no test failures while they are not working. Therefore I suggest that we remove these two truncate calls in D7 entirely. I have proposed the same solution for D10.
Comment almost 2 years ago →
🇩🇪Germany Anybody Porta Westfalica
What do we have to do to get this Drupal 7 fix into core after nearly 10 years?
Status changed to Needs work almost 2 years ago7:57pm 2 May 2023
Comment almost 2 years ago →
🇸🇰Slovakia poker10
I propose to update the patch - instead of fixing the truncate calls let's remove both of them, because these are not needed at all (I suggested the same approach in the D10 patch). And if possible, please upload a new patch together with test-only patch, so that we can also see the failure in test results.

I will add this issue to the next release META issue: 📌 [meta] Priorities for 2023-06-07 release of Drupal 7 Fixed , so that it has a greater chance of being committed. I cannot guarantee it, but we will try to take a look at this issue as well. Thanks!
Comment almost 2 years ago →
🇸🇰Slovakia poker10
Just for info, the removal of trucate call(s) was committed to D10 today, so it seems to be the correct approach: 🐛 StatisticsLoggingTest does not truncate node_counter Fixed

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024