Split VocabularyFormController into VocabularyAddForm and VocabularEditForm

Created on 13 March 2014, almost 11 years ago
Updated 11 December 2023, about 1 year ago

Updated: Comment #0

Problem/Motivation

#2214063: 'Add vocabulary' page doesn't display correct page title. β†’ introduced a if ($entity->isNew()) {} check to VocabularyFormController. We're trying to avoid such checks in favor of dedicated form classes for add and delete forms which inherit from a base form class.

Proposed resolution

  • Rename VocabularyFormController to VocabularyFormBase and move it into the Drupal\taxonomy\Form namespace
  • Create a Drupal\taxonomy\Form\VocabularyAddForm and a Drupal\taxonomy\Form\VocabularyEditForm that both extend VocabularyFormBaseand move the declaration of $form['#title'] there.
  • Register the new forms in the entity annotation
  • Profit

Remaining tasks

User interface changes

API changes

πŸ“Œ Task
Status

Closed: duplicate

Version

9.5

Component
TaxonomyΒ  β†’

Last updated 39 minutes ago

  • Maintained by
  • πŸ‡ΊπŸ‡ΈUnited States @xjm
  • πŸ‡¬πŸ‡§United Kingdom @catch
Created by

πŸ‡©πŸ‡ͺGermany tstoeckler Essen, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024