Contrib.social

ExtensionDiscovery::getProfileDirectories() explicitly skips parent installation profile in installer, defeating its purpose

Open on Drupal.org →
Created on 16 January 2014, over 10 years ago
Updated 7 November 2023, 7 months ago

Problem

  • ExtensionDiscovery::getProfileDirectories() explicitly skips the simpletest parent installation profile processing in the installer, which seemingly defeats the entire purpose of that environment value:
         // For SimpleTest to be able to test modules packaged together with a
     // distribution we need to include the profile of the parent site (in
     // which test runs are triggered).
     // @todo !drupal_installation_attempted() defeats the whole purpose?
     if (drupal_valid_test_ua() && !drupal_installation_attempted()) {
       $testing_profile = \Drupal::config('simpletest.settings')->get('parent_profile');

    (Note the code comment.)

  • This means that additional modules that may be provided by an installation profile are not actually discovered when Drupal is installed in a web test.
🐛 Bug report
Status

Closed: outdated

Version

11.0 🔥

Component
Extension  →

Last updated 3 days ago

No maintainer
Created by

🇩🇪Germany sun Karlsruhe

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇳🇿New Zealand quietone New Zealand

    I skimmed the comments and see that in #38 this has either been fixed or the test is not testing what it should be. That comment was 7 years ago. There has been no further discussion here which may suggest that this has, indeed, been fixed.

    I did some research and found that the code changed in the patch (not the test) was removed from core in #3081501: Remove TestSetupTrait::$originalProfile and test infrastructure which uses it → . As for the test, there is similar testing done in \Drupal\Tests\system\Kernel\Common\SystemListingTest::testFileScanIgnoreDirectory which seems to be showing the modules in install profiles are discovered. So, this does appear to be outdated.

    I will check in #bugsmash. For now, setting to PMNMI.

  • Status changed to Closed: outdated 7 months ago
  • Comment 7 months ago →
    🇳🇿New Zealand quietone New Zealand

    There has been no further discussion to suggest that this is still a problem. Therefor, closing as outdated based on #52.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024