Prevent taxonomy_forums field be removed in admin interface

Open on Drupal.org →

Created on 1 December 2013, over 10 years ago

Updated 24 April 2024, 2 months ago

The taxonomy_forums field can be removed in /admin/structure/types/manage/forum/fields page.

To reproduce this bug :
1) 1. install drupal 8.0.x locally
2) go to /admin/structure/content types/manage/forum/fields
3) click on manage field in front of forum field and delete it.

After the field be removed, will cause a lot of issues in forum.module, here is an example issue:

Fatal error: Call to a member function getBundles() on a non-object in /home/hej/src/php/drupal8/core/modules/forum/forum.module on line 151

Call Stack:
0.0000 644528 1. {main}() /home/hej/src/php/drupal8/index.php:0
0.0013 932624 2. drupal_handle_request() /home/hej/src/php/drupal8/index.php:15
0.0281 3811328 3. Drupal\Core\DrupalKernel->handle() /home/hej/src/php/drupal8/core/includes/bootstrap.inc:1880
0.0285 3913536 4. Drupal\Core\HttpKernel->handle() /home/hej/src/php/drupal8/core/lib/Drupal/Core/DrupalKernel.php:282
0.0285 3915064 5. Symfony\Component\HttpKernel\HttpKernel->handle() /home/hej/src/php/drupal8/core/lib/Drupal/Core/HttpKernel.php:52
0.0285 3915064 6. Symfony\Component\HttpKernel\HttpKernel->handleRaw() /home/hej/src/php/drupal8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:61
0.0537 5233392 7. call_user_func_array() /home/hej/src/php/drupal8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:117
0.0537 5234008 8. Drupal\Core\Controller\HtmlPageController->content() /home/hej/src/php/drupal8/core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/HttpKernel.php:0
0.2079 8967536 9. drupal_render_page() /home/hej/src/php/drupal8/core/lib/Drupal/Core/Controller/HtmlPageController.php:100
0.2422 10864728 10. drupal_render() /home/hej/src/php/drupal8/core/includes/common.inc:3678
0.2423 10868472 11. theme() /home/hej/src/php/drupal8/core/includes/common.inc:3886
0.2439 11082464 12. template_preprocess_page() /home/hej/src/php/drupal8/core/includes/theme.inc:718
0.2533 11275424 13. menu_get_local_actions() /home/hej/src/php/drupal8/core/includes/theme.inc:2359
0.2533 11275424 14. menu_local_tasks() /home/hej/src/php/drupal8/core/includes/menu.inc:2210
0.2569 11360800 15. forum_menu_local_tasks() /home/hej/src/php/drupal8/core/includes/menu.inc:2005

So we should lock the taxonomy_forums field to prevent it be removed from admin interface.

📌 Task

Status

Needs work

Version

1.0

Component

forum.module

Created by

🇨🇳China jian he

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

SprintWeekend2016

Bug Smash Initiative

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Status changed to Postponed over 1 year ago9:59am 7 February 2023
Comment over 1 year ago →
🇳🇿New Zealand quietone New Zealand
Forum is approved for removal. See #1898812: [policy] Deprecate forum module for removal in Drupal 11 →

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

It will be moved to the contributed extension → once the Drupal 11 branch is open.
Status changed to Needs work 2 months ago1:53am 24 April 2024
Comment 2 months ago →
🇳🇿New Zealand quietone New Zealand

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024