Modernize file.module forms

Can we update the title about what's being accomplished here.

Thanks but think the actual title needs to updated.

looking in the file module there appear to be other test forms if we are just adding typehints?

I've updated the title.
I did a search and didn't found additional instances except one kernel test which we can't update

grep -r 'implements FormInterface' core/modules/file/tests

Should be fine then

Great cleanup! Saving credits.

There is something strange going on with the issue summary. I usually use the link to view the original issue summary to see if the original issue report was helpful, but it's missing. The original revision is also missing from the revision log and it appears the first revision is from @plopesc.

However, I'm going to err on the side of assuming the best and grant credit. (If it turns out to be a mistake we can fix it later.)

It appears that this will be @alexanansi's first issue credit in the crediting system. So, I did some git archaeology:

[ayrton:drupal | Sat 07:11:08] $ git log --grep="alexanansi"
commit 0cf2996a30bf52025a0b06e395dbcb87cb56cb67
Author: Alex Pott <alex.a.pott@googlemail.com>
Date:   Tue Jul 15 10:22:56 2014 +0100

    Issue #2078015 by er.pushpinderrana, RoSk0 | alexanansi: Modernize views_test_data.module forms.

commit 683223968a44fc83e94cd406c81805b4f627c89a
Author: webchick <webchick@24967.no-reply.drupal.org>
Date:   Fri Mar 21 10:36:33 2014 -0700

    Issue #2078001 by RoSk0, JayeshSolanki | alexanansi: Modernize responsive_image.module forms.

Looks like @alexanansi helped with these form cleanups back during D8 development, and this poor issue just happened to slip the net into the 2020s. :) Thanks @alexanansi, and thanks @mohit_aghera for reviving it!

Committed to 11.x and 11.2.x, running PHPStan locally both times. I was tempted to backport it to 10.6.x and 10.5.x as a test cleanup, but maybe we should not be making baseline changes on the maintenance minor anymore. So marking fixed for now.

Thanks everyone!

xjm → closed merge request !12239

Trying again to save @alexanansi's credit, this time in a different browser.

Now testing with JS disabled.

xjm → credited alexanansi → .

This time manually entering alexanansi in the "Credit others" field.

Crediting @fjgarlin for helping me debug crediting. :)