- 🇺🇸United States bradjones1 Digital Nomad Life
I'm going to mark this a duplicate of 📌 Allow plugin service wiring via constructor parameter attributes Needs work which seems to target the underlying issue more broadly for plugin types of all kinds.
Updated: Comment #72
Typed data plugins need to have dependencies injected. See #2903549: Replace REQUEST_TIME with time service in CreatedItem → as an example of plugin that can benefit from this
1. Make TypedDataManager container aware (use ContainerAwareTrait)
2a. Check if created plugin implements ContainerAwareInterface, and if yes, call its setContainer() method.
2b. Check if plugin definition contains "services" section. If no - same logic as before. If yes,
3a. Inject services in additional parameter of createInstance()
3b. Assume that plugin implements ContainerFactoryPluginInterface, call ContainerFactoryPluginInterface::create()
3c. Directly call plugin constructor
2a is 2a and 3b are fully backwards compatible.
3a should be BC as well (on assumption that no plugins use extra parameters to createInstance())
Decide what is the best approach
Write the patch
Test it
Review it
None
Add @service_container as a parameter of typed_data_manager service
#1951268: Convert /forum and /forum/% to new router, remove forum_forum_load(), forum_get_topics(), create Forum service →
✨
Allow Plugins to specify Services via Annotation
Closed: duplicate
Closed: duplicate
11.0 🔥
Changes an existing API or subsystem. Not backportable to earlier major versions, unless absolutely required to fix a critical bug.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I'm going to mark this a duplicate of 📌 Allow plugin service wiring via constructor parameter attributes Needs work which seems to target the underlying issue more broadly for plugin types of all kinds.