Menu routing has many problems

Created on 30 March 2013, about 11 years ago
Updated 29 March 2023, over 1 year ago

The menu routing uses many static paths that grow in number when more clients and states are added.
e.g.
'support/$client->path/$state'
'support/$client->path/$subclient->path'
These should use % variables to limit menu router paths

There are also pages that server the same function using different URLs
'support/$client->path' and 'support/$client->path/all' show the same content

Also using text variables for client path and state causes many issues. Only id's should be passed and then use a module like pathauto and tokens to safely create text aliases. there are paths like 'my%20open' and 'all%20open'. support_admin_client_validate() does not even check format of client paths.

I suggest paths like:

support/client/%
support/client/%/state/%
support/user/%
support/user/%/state/%

Any page that allows editing of other user's information should begin with 'admin/support' for security. normal users would see one set of pages that show tickets they created or have view access to. All other pages would be adminstrative.

Scrap subclient paths since all the data can be loaded using $client->clid.

I am going to take a stab at creating a 6.x-1.x-dev patch since I have more clients still on D6.

πŸ› Bug report
Status

Closed: outdated

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024