- last update
over 1 year ago 59 pass - 🇺🇸United States dsnopek USA
Here's a re-roll of patch #83, but where the cache entries expire after 1 hour, in order to work around the cache ballooning issue.
If a view uses ajax, and user can able to change Items per page value + pager exits, the pager won't work as well, if 'items per page' has different value, than the original view's pager option.
To reproduce: Create a view pane, Set pager to 'Paged output, full pager', and set 'Items to display' on views pager settings form to 10. On pane configuration let the 'Allow settings' check 'Items per page'.
Then add a new pane, and set 'Item per page' on pane input form to 1.
On page load, the 1 item will show up with pager. Then use pager, the result will be 10 item, as in the original view was set up.
This is, because the ajax callback of views just load the default view settings, and give back $this->preview() as result. No chance to add the pane's own parameters.
I'm not sure how do we need to handle this.. I tried to extend the preview() in views_content_plugin_display_panel_pane.inc, but I didn't get any relevant information from exisiting variables. The one of my idea to pass number of items by url, but I'm not sure, this is the best way (I think, we could have other pane settings, which would be lost)
Needs review
1.0
Views Content
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Here's a re-roll of patch #83, but where the cache entries expire after 1 hour, in order to work around the cache ballooning issue.