- First commit to issue fork.
- Assigned to aangel
- 🇺🇸United States aangel
I've done some manual testing, added some tests that handle the three types of date fields (I think what I did should work without the Date module being required) and added other filtering tests.
- Status changed to Needs work
9 months ago 9:17pm 12 April 2024 - 🇺🇸United States drumm NY, US
This project has switched to GitLab CI, so merge requests should be used instead of patch files.
- Merge request !2Issue #1910294: Ability to filter with comparison parameters (smaller/larger than) → (Open) created by froboy
- 🇺🇸United States froboy Chicago, IL
@drumm it looks like @aangel did open a branch, but missed creating the MR. I've done that: https://git.drupalcode.org/project/restws/-/merge_requests/2
- Status changed to Needs review
9 months ago 6:39pm 23 April 2024 - 🇺🇸United States froboy Chicago, IL
@drumm I see a bunch of phpcs errors/warnings, but I'd imagine much of that is preexisting tech debt and not from the changes in this issue. How would you recommend moving forward?
- 🇺🇸United States aangel
Yes, those phpcs warnings were there before and I didn't want to expand the MR with non-issue related changes. I might have fixed a very few things but not many.
- 🇮🇳India vineshmalviya
Updated patch to fix the issue
When using the webservice and doing search using operators like ct or sw error was thrown and searches are not done.
eg search using search_data.json?field_first_name[ct]=vinesh
This will through error when search done on profile field with contain operatorWe have done changes to fix the way search is handled when contain or start with operator passed in web service search
in restws.entity.inc - 🇺🇸United States froboy Chicago, IL
@vineshmalviya it looks like you're new here, welcome! You've uploaded a patch to an issue with a MR. Please review Using GitLab to Contribute to Drupal → to understand the new workflow. I'd also recommend adding some more complete test steps so that we can properly validate the problem you're seeing.
Thanks!
(also doing cleanup to hide patch files since this in using a MR now)