Aggregator module blocks - add '1' to news item # array

I've been ignoring this simple issue because I want to do away with the block plugins in favor of a view. After that it won't be a problem anymore. But when I started working on the view today I realized that we'll need to leave the plugin in the module until version 3 is released for backward compatibility. That's because there may be instances of the blocks such as those in Layout Builder that can't be automatically replaced by an update function. So some sites may choose to continue using the plugin for a while. We may as well fix this for them.

+++ b/tests/src/Functional/AggregatorRenderingTest.php
@@ -83,6 +83,17 @@ class AggregatorRenderingTest extends AggregatorTestBase {
+  /**
+   * Tests the elements of the AggregatorFeedBlock settings form.
+   */
+  function testBlockSettingsForm() {
+    $this->drupalGet('/admin/structure/block/add/aggregator_feed_block/olivero');
+
+    foreach (range(1, 20) as $value) {
+      $this->assertSession()->optionExists('edit-settings-block-count', $value);
+    }
+  }

I am of the opinion that we don't need to test this, its a trivial change and we're wasting cpu cycles/time on each PR testing it, but happy for it to stay if you feel otherwise

I am of the opinion that we don't need to test this, its a trivial change and we're wasting cpu cycles/time on each PR testing it

I agree. I was just trying to be thorough. I'll remove it from the patch.

Thanks to everyone who worked on this!

Automatically closed - issue fixed for 2 weeks with no activity.