- π©πͺGermany mkalkbrenner π©πͺ
We facing the same issue. Rather than a login history we need an activity history. Ideally one entry per day if the user does anything.
- Assigned to mkalkbrenner
- π©πͺGermany mkalkbrenner π©πͺ
I implemented a protoype. I'll polish it a bit and upload a patch here.
- Status changed to Needs review
about 1 year ago 9:22am 22 September 2023 - π©πͺGermany mkalkbrenner π©πͺ
This patch adds the feature. It is mostly complete.
If it gets accepted, I could add a a settings page for the new settings. But you can already adjust them via config management or overwrites. - π©πͺGermany mkalkbrenner π©πͺ
Forgot to
handle activity_log_interval: 0
to turn activity logging off. - last update
about 1 year ago Composer require failure - Issue was unassigned.
- π©πͺGermany mkalkbrenner π©πͺ
The patch is against 2.x. Unfortunately the 2.x branch is not enabled for testing.
- π©πͺGermany mkalkbrenner π©πͺ
Here's an adjusted version of the patch against 2.x-dev.
- π©πͺGermany mkalkbrenner π©πͺ
Another adjustment to resolve the conflict with in the update hook.
Nice work @mkalkbrenner, serving my particular use case perfectly with minimal config and disruption
- π¨π¦Canada avo webworks Ottawa, Ontario, Canada
Wonderful patch #17 works well and this is a great addition to the module. Thank you for your work @mkalkbrenner!
Great if this can be committed to the module.
- π΅πΉPortugal jcnventura
So, camslice and avo webworks, do you still believe that this still needs a review? What I read from your non-change of status is that you tested, and think it works, but you consider that you didn't test it completely.
Please refer to https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... β for what the status field in an issue means.
- π¨π¦Canada avo webworks Ottawa, Ontario, Canada
Hello @jcnventura.
This patch works for me but I am hesitant to set the patch status to "RTBC" as described in the link you had me refer to I quote:
"Setting an issue to this status is a judgment call: if you have thoroughly tested and reviewed the patch and believe it is ready, you may change the status. If you are unsure, the status should not be changed. Simply add the findings of your review to the issue.Remember that even if one or two community members believe an issue is ready, that doesn't necessarily mean that it will be committed. If it is not, it can be reverted to an earlier status. The better the reviews, the more likely the code will actually get committed."
Personally, it would be great if we had a few more folks test before marking it RTBC...
Having said that this patch is a fantastic addition to the module in order to also track sessions.
Thank you for this module and the work folks have done on it!