Constants should be checked if defined before being set

Created on 13 December 2012, over 12 years ago
Updated 2 May 2025, 2 months ago

Some settings like DOMAIN_INSTALL_RULE or DOMAIN_SITE_GRANT need to be modified in the domain.module to take effect. In my opinion, these constants should be overridden in Drupal settings.php, so that we don't need to change the module's source code. If so, we don't need to modify the source whenever the module is upgraded to newer version.

Just modify the domain.module like below:

if (!defined('DOMAIN_INSTALL_RULE')) 
   define('DOMAIN_INSTALL_RULE', TRUE);
✨ Feature request
Status

Closed: outdated

Version

3.5

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia sonnykt Melbourne, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024