Avoid breaking whole save process at default processor when there are faulty item(s)

The originally-reported database exception is still reproduceable in Drupal 10.1.

Drupal\Core\Entity\EntityStorageException: SQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'timestamp' at row 1: INSERT INTO "aggregator_item" ("langcode", "fid", "title", "link", "author", "description", "timestamp", "guid") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7); Array ( [:db_insert_placeholder_0] => en [:db_insert_placeholder_1] => 14 [:db_insert_placeholder_2] => Bad timestamp feed item title. [:db_insert_placeholder_3] => http://example.com/bad/timestamp [:db_insert_placeholder_4] => [:db_insert_placeholder_5] => This item has a very old timestamp, which is known to have caused a PDOException that breaks the entire import process. See https://www.drupal.org/project/aggregator/issues/1695852 🐛 Avoid breaking whole save process at default processor when there are faulty item(s) Fixed . [:db_insert_placeholder_6] => -2209172400 [:db_insert_placeholder_7] => http://example.com/bad/timestamp ) in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 815 of core\lib\Drupal\Core\Entity\Sql\SqlContentEntityStorage.php).

I'm not happy with the current state of testing the importing pipeline. Because there are dependency problems in the pipeline the processor is tested in bits in other places. But although we have a test that ensures that the processor plugin system works correctly, we don't have a test just for the DefaultProcessor plugin's functionality. So I made one. It ought to be expanded to test for everything that the DefaultProcessor does, but for now this patch contains a test for the problem that kicked off this issue. Locally, this patch is failing with the exception shown in the comment above.

I forgot to add the @group to the new test class.

The last submitted patch, 23: 1695852-23-test-only.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

I made some modifications from #6. Instead of wrapping the entire contents of the foreach loop in the try block I only wrapped the item's save() call. And instead of checking broadly for any Exception, I changed it to specifically catch EntityStorageExceptions. Also, I had to implement the logger channel because #6 was written in the D7 era.

I updated the new test class' docblock and removed an unneeded use statement.

I've been avoiding committing some of these recent patches because I want them to be checked first. But this one is a straightforward bug fix that corrects an uncaught exception. So I didn't mind getting this one in.

Automatically closed - issue fixed for 2 weeks with no activity.