Audit the code for FacetapiFacet::getSettings() calls and replace with FacetapiAdapter::getFacetSettings*()

Created on 29 June 2012, almost 13 years ago
Updated 30 May 2025, 11 days ago

Settings used to be retrieved from FacetapiFacet::getSettings(), however for better caching most of the logic was moved to the FacetapiAdapter::getFacetSettings*() methods, while keeping FacetapiFacet::getSettings() as a convenience method. We should audit the code for FacetapiFacet::getSettings() and replace with FacetapiAdapter::getFacetSettings*() methods as necessary, as it would eliminate some extra logic and a method call per instance.

📌 Task
Status

Closed: outdated

Version

1.0

Component

User interface

Created by

🇺🇸United States cpliakas

Live updates comments and jobs are added and updated live.
  • API clean-up

    Refactors an existing API or subsystem for consistency, performance, modularization, flexibility, third-party integration, etc. May imply an API change. Frequently used during the Code Slush phase of the release cycle.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    I am closing this issue, which was created for a project version compatible with a Drupal release no longer supported. Feel free to re-open the issue, if it is still relevant for a project version compatible with a supported Drupal release.

Production build 0.71.5 2024