help_menu() creates unnecessary router items

Created on 6 June 2012, almost 13 years ago
Updated 27 March 2025, 21 days ago

  foreach (module_implements('help') as $module) {
    $items['admin/help/' . $module] = array(
      'title' => $module,
      'page callback' => 'help_page',
      'page arguments' => array(2),
      'access arguments' => array('access administration pages'),
      'type' => MENU_VISIBLE_IN_BREADCRUMB,
      'file' => 'help.admin.inc',
    );
  }

All this needs is a title callback as far as I can tell, then it should work with a single router item.

πŸ› Bug report
Status

Closed: outdated

Version

7.0 ⚰️

Component

help.module

Created by

πŸ‡¬πŸ‡§United Kingdom catch

Live updates comments and jobs are added and updated live.
  • Needs backport to D7

    After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States Amber Himes Matz Portland, OR USA

    I have discussed this issue in the #bugsmash Slack channel, and @catch advised that if this issue was a pure backport issue to D7, it should be marked as closed (outdated), because Drupal 7 is End-Of-Life (EOL).

    It does look like this is a pure D7 backport issue, so I am closing this issue as outdated.

    Thank you to everyone who worked on this issue.

  • πŸ‡ΊπŸ‡ΈUnited States Amber Himes Matz Portland, OR USA

    I just learned that closed issues (as in the work on the D7 backport which was not committed) now can give credit, even if no work was committed.

    So adding credit for @foxtrotcharlie and @star-szr for patches and review work that they did. I hope it's not too late for the credit to be added! Thank you again for your past work on this.

Production build 0.71.5 2024