Add tests for reverting revisions where revision_uid and uid differ

Does appear to be a duplicate of 🐛 Revision user incorrectly appears as anonymous user when node author is cancelled Needs work could anyone confirm?

Re #50 no it's not a duplicate, this is purely about adding test coverage for reverting Node revisions.

I've applied #35 and updated (basically a full rewrite) with our new testing API. Mainly this involved fixing deprecated functions and I ended up moving everything out of class properties into the test case itself so it was easier to manage.

However, one expectation is no longer true - the last assert that checks the revision user is the initial revision user. NodeRevisionRevertForm explicitly sets the revision user of a reverted revision to the current (logged in) user. That is by design and has persisted to the generic revision UI as well.

left some comments on the MR

Unresolved the 2 threads and see if the core committers are fine with it,

I did search for pageTextContains(\sprintf and didn't find any instances in core

I did search for pageTextContains(\sprintf and didn't find any instances in core

Probably because hardly anyone uses the backslash. Look for sprintf in anything *Test.php and you'll find plenty :)

https://git.drupalcode.org/search?group_id=2&nav_source=navbar&project_i...