Remove $op from hook_node_grant and hook_node_grant_alter

Created on 6 March 2012, about 13 years ago
Updated 19 March 2025, 18 days ago

Problem/Motivation

In issue #611772: Node access hooks don't quite make sense... β†’ and identified again in πŸ“Œ [meta] Remove the last $op params from our hooks Active , it was suggested to remove the $op from the function, because of the functions already established in hook_node_access_records.

Proposed resolution

Patch is attached.

πŸ“Œ Task
Status

Postponed: needs info

Version

11.0 πŸ”₯

Component

node system

Created by

πŸ‡ΊπŸ‡ΈUnited States chertzog Harrisburg, PA, USA

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¦πŸ‡ΊAustralia acbramley

    Is this still something we want to do? As per #4 it seems like functionality that might be used, I'm struggling to find examples in gitlab though.

    The hooks are fired from the node_access_grants function, that function is called in several places with a hardcoded view operation, but NodeAccesControlHandler does pass in the $operation to NodeGrantDatabaseStorage::access which is passed to node_access_grants.

Production build 0.71.5 2024