Created on 7 February 2012, about 13 years ago
Updated 23 January 2025, 2 months ago

Checking compliance with the w3 standards using http://validator.w3.org returns a few errors such as:

  • There are non standard attributes in spans such as "st_url"
  • There should be quotes wrapping the value of attributes, this is regarding "st_url" again.
  • There's an endtag for span which isn't currently open. This is caused by the above error because the / in http:// is interpreted as the endtag since it's not in quotes.

I propose that the information in the attributes of each span can be put into a javascript variable, this way the markup can be standard complient, and since this module already depends on javascript it wouldn't hinder the performance if the client browser doesn't support javascript.

The array could look somewhat like this.

var shareThis_info =
  {
    st_facebook_large:
      {
        st_url:"http://www.google.com",
        st_title:"Google",
        displaytext:"Facebook"
      },
    etc...
  };

This way you can use the class as the key to quickly get the information of the currently active span via javascript.

πŸ› Bug report
Status

Closed: outdated

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States BAM5

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024